Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor only, add StreamWriter to AppendRowsRequestResponse #1981

Merged
merged 6 commits into from
Feb 10, 2023
Merged

fix: refactor only, add StreamWriter to AppendRowsRequestResponse #1981

merged 6 commits into from
Feb 10, 2023

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Feb 7, 2023 •
edited
Loading

  1. The stream name of the writer can be used for separate queue processing when we start to add per table ordering.
  2. It allows us to callback on streamwriter for its internal counter, so we can close the streamwriter with inflight requests done.

@yirutang
fix: refactor only, add StreamWriter to AppendRequestResponse, so tha…
7c092d6 
…t we could callback on StreamWriter to manage its close
@yirutang
.
b4b5c0c
@yirutang yirutang requested review from a team and alvarowolfx February 7, 2023 22:19
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Feb 7, 2023
@yirutang yirutang requested a review from GaoleMeng February 7, 2023 22:45
GaoleMeng
GaoleMeng reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@GaoleMeng GaoleMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need streamwriter to the appendRowsRequestResponse?

@yirutang
Copy link
Contributor Author

yirutang commented Feb 9, 2023

Why do we need streamwriter to the appendRowsRequestResponse?

As stated in description, there are two potential usage of this:

  1. To callback on StreamWriter when we got a response, so that on SW close, we can wait for the count to go down to 0. I am going to send out a PR about this as next step.
  2. When we add the appendRowsRequestResponse, we can use the StreamName to build up a separate queue for each different StreamName.

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 10, 2023 18:56
@yirutang yirutang added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2023
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 10, 2023
@yirutang yirutang merged commit da06a46 into googleapis:main Feb 10, 2023
@release-please release-please bot mentioned this pull request Feb 10, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 14, 2023
@release-please
chore(main): release 2.31.1 (#1994)
585359c 
🤖 I have created a release *beep* *boop*
---


## [2.31.1](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.31.0...v2.31.1) (2023-02-14)


### Bug Fixes

* Refactor only, add StreamWriter to AppendRowsRequestResponse ([#1981](https://togithub.com/googleapis/java-bigquerystorage/issues/1981)) ([da06a46](https://togithub.com/googleapis/java-bigquerystorage/commit/da06a4623e89b5f3caf90f85dd87d8538fc7d312))
* Support ByteString values on repeated fields ([#1996](https://togithub.com/googleapis/java-bigquerystorage/issues/1996)) ([0263b00](https://togithub.com/googleapis/java-bigquerystorage/commit/0263b0054fbb7d9f49157f507cfe11c5b5816b07))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaoleMeng GaoleMeng GaoleMeng approved these changes

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. kokoro:run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yirutang @GaoleMeng @yoshi-kokoro